missing source file; hook declined update

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

missing source file; hook declined update

Olaf Leidinger
Dear all,

I'm trying to submit the following new PKGBUILD:

# Maintainer: Olaf Leidinger <[hidden email]>
#
# Get the CentOS tarball from https://www.codeplay.com/products/computesuite/computecpp/download
pkgname=computecpp
pkgver=0.2.1
pkgrel=1
pkgdesc="Accelerates Complex C++ Applications on Heterogeneous Compute Systems using Open Standards"
arch=('x86_64')
url="https://www.codeplay.com/products/computesuite"
license=('EULA')
source=("file://ComputeCpp-CE-${pkgver}-CentOS-64bit.tar.gz")
sha256sums=('e7e301bcd8906b419d0067c262dc0eac987798da9dbac4763d285c1e9bf8ddec')

package() {
    _pkgbasename=ComputeCpp-CE-${pkgver}-Linux
    cd "$srcdir"
    mkdir -p "$pkgdir/opt"
    mkdir -p "$pkgdir/usr/bin"
    mkdir -p "$pkgdir/etc/ld.so.conf.d"

    mv ${_pkgbasename} "$pkgdir/opt"

    ln -s /opt/${_pkgbasename}/bin/compute++ "$pkgdir/usr/bin"
    ln -s /opt/${_pkgbasename}/bin/computecpp_info "$pkgdir/usr/bin"

    echo /opt/${_pkgbasename}/lib > "$pkgdir/etc/ld.so.conf.d/computecpp.conf"
}

This is the corresponding .SRCINFO file:

pkgbase = computecpp
        pkgdesc = Accelerate Complex C++ Applications on Heterogeneous Compute Systems using Open Standards
        pkgver = 0.2.1
        pkgrel = 1
        url = https://www.codeplay.com/products/computesuite
        arch = x86_64
        license = EULA
        source = file://ComputeCpp-CE-0.2.1-CentOS-64bit.tar.gz
        sha256sums = e7e301bcd8906b419d0067c262dc0eac987798da9dbac4763d285c1e9bf8ddec

pkgname = computecpp


On pushing, I get:

$ git push --set-upstream origin master

Counting objects: 11, done.
Delta compression using up to 16 threads.
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.71 KiB | 0 bytes/s, done.
Total 11 (delta 3), reused 0 (delta 0)
remote: error: The following error occurred when parsing commit
remote: error: 340c3119f9661343b5067bf848aaee0ac56a0028:
remote: error: missing source file: ComputeCpp-CE-0.2.1-CentOS-64bit.tar.gz
remote: error: hook declined to update refs/heads/master
To ssh://aur.archlinux.org/computecpp.git
 ! [remote rejected] master -> master (hook declined)
error: failed to push some refs to
'ssh://[hidden email]/computecpp.git'

Any idea what's wrong? According to my research, prepending file:// is
the way to go for packages with fetch restriction.

Thanks for your insight,

Olaf


signature.asc (879 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: missing source file; hook declined update

Doug Newgard-2
On Thu, 27 Jul 2017 15:01:30 +0200
Olaf Leidinger <[hidden email]> wrote:

> remote: error: 340c3119f9661343b5067bf848aaee0ac56a0028:

Does this commit contain file:// in the source entry in .SRCINFO?
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: missing source file; hook declined update

Eli Schwartz-2
On 07/27/2017 09:09 AM, Doug Newgard wrote:
> On Thu, 27 Jul 2017 15:01:30 +0200
> Olaf Leidinger <[hidden email]> wrote:
>
>> remote: error: 340c3119f9661343b5067bf848aaee0ac56a0028:
>
> Does this commit contain file:// in the source entry in .SRCINFO?

+1

You almost certainly added a commit without file:// and then added a new
commit to fix that. But the AUR validates every commit, not just the
contents of the final pushed commit, so you'll need to rebase...

--
Eli Schwartz


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: missing source file; hook declined update

Olaf Leidinger
In reply to this post by Doug Newgard-2
On 27 July 2017 15:09:05 CEST, Doug Newgard <[hidden email]> wrote:
>Does this commit contain file:// in the source entry in .SRCINFO?

It does, c.f the srcinfo file in the original mail.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: missing source file; hook declined update

Eli Schwartz-2
On 07/27/2017 10:39 AM, Olaf Leidinger wrote:
> On 27 July 2017 15:09:05 CEST, Doug Newgard <[hidden email]> wrote:
>> Does this commit contain file:// in the source entry in .SRCINFO?
>
> It does, c.f the srcinfo file in the original mail.

I would really double-check if I were you.

https://git.archlinux.org/aurweb.git/tree/aurweb/git/update.py?h=v4.5.1#n338

See the block 'if "://" in fname or "lp:" in fname: continue'

...

Use `git show 340c3119f9661343b5067bf848aaee0ac56a0028:.SRCINFO` to
check what the AUR validator is actually looking at.

--
Eli Schwartz


signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: missing source file; hook declined update

Olaf Leidinger

> Use `git show 340c3119f9661343b5067bf848aaee0ac56a0028:.SRCINFO` to
> check what the AUR validator is actually looking at.
That was the key! It would seem that the hook analyzes individual
commits, but not the last version. I started out without file://, but
added it on the second commit. Squashing it all together and doing a
force push solved the problem. Thanks :)


signature.asc (879 bytes) Download Attachment
Loading...