wrong description of configure switches

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

wrong description of configure switches

Roman Kyrylych
Hi!
I was trying to build pacman3 few minutes ago and noticed that some
configure switches have wrong descriptions:
  --enable-man2html       Build html docs via man2html
  --disable-po4a          Build localized manpages via po4a
  --disable-doxygen       Build API docs via Doxygen
  --disable-python        Build Python bindings
  --disable-perl          Build Perl bindings
  --disable-java          Build Java bindings
  --enable-debug    Enable debugging support

Here --disable-* should not be described as "Build something", but "Do
not build something" instead.

--
Roman Kyrylych (Роман Кирилич)
_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev
Reply | Threaded
Open this post in threaded view
|

Re: wrong description of configure switches

Miklos Vajna
On Wed, Oct 25, 2006 at 12:14:48PM +0300, Roman Kyrylych <[hidden email]> wrote:
> Here --disable-* should not be described as "Build something", but "Do
> not build something" instead.

could you please send a patch?

thanks,
VMiklos

--
Developer of Frugalware Linux, to make things frugal - http://frugalware.org

_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev
Reply | Threaded
Open this post in threaded view
|

Re: wrong description of configure switches

Roman Kyrylych
2006/10/25, VMiklos <[hidden email]>:
> On Wed, Oct 25, 2006 at 12:14:48PM +0300, Roman Kyrylych <[hidden email]> wrote:
> > Here --disable-* should not be described as "Build something", but "Do
> > not build something" instead.
>
> could you please send a patch?

Maybe. I just started to read diff/patch tutorial today. :-)

--
Roman Kyrylych (Роман Кирилич)
_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev
Reply | Threaded
Open this post in threaded view
|

Re: wrong description of configure switches

Miklos Vajna
On Wed, Oct 25, 2006 at 12:47:02PM +0300, Roman Kyrylych <[hidden email]> wrote:
> Maybe. I just started to read diff/patch tutorial today. :-)

1) cp -a pacman-lib pacman-lib.orig

2) edit a file inside pacman-lib

3) diff -Naur pacman-lib.orig pacman-lib > foo.diff

4) ensure that foo.diff contains only what you want and send it

to apply a patch:

1) cd pacman-lib

2) patch -p1 < foo.diff

that's all :)

udv / greetings,
VMiklos

--
Developer of Frugalware Linux, to make things frugal - http://frugalware.org

_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev
Reply | Threaded
Open this post in threaded view
|

Re: wrong description of configure switches

Roman Kyrylych
2006/10/25, VMiklos <[hidden email]>:

> On Wed, Oct 25, 2006 at 12:47:02PM +0300, Roman Kyrylych <[hidden email]> wrote:
> > Maybe. I just started to read diff/patch tutorial today. :-)
>
> 1) cp -a pacman-lib pacman-lib.orig
>
> 2) edit a file inside pacman-lib
>
> 3) diff -Naur pacman-lib.orig pacman-lib > foo.diff
>
> 4) ensure that foo.diff contains only what you want and send it
>
> to apply a patch:
>
> 1) cd pacman-lib
>
> 2) patch -p1 < foo.diff
>
> that's all :)
Thanks! It may sound strange but I develop in asm/C/PHP for many years
and have never made a single patch with diff. :-D (That's because I
mostly developed my own projects and other devs that I send some fixed
versions to were developing their libraries on Windows.)

So, here's my first "real" patch ever made. :-D


--
Roman Kyrylych (Роман Кирилич)

_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev

configure-switches-fix.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: wrong description of configure switches

Miklos Vajna
On Wed, Oct 25, 2006 at 01:16:19PM +0300, Roman Kyrylych <[hidden email]> wrote:
> So, here's my first "real" patch ever made. :-D

thanks:

http://frugalware.org/pipermail/frugalware-darcs/2006-October/022571.html

udv / greetings,
VMiklos

--
Developer of Frugalware Linux, to make things frugal - http://frugalware.org

_______________________________________________
pacman-dev mailing list
[hidden email]
http://www.archlinux.org/mailman/listinfo/pacman-dev